refactor: Compile(ecc.ID) -> Compile(field *big.Int) #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivokub
requested changes
Jun 7, 2022
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
I think that in general the changes make sense. I'm just thinking that maybe it would be better to name the modulus variable as primeFieldModulus etc? If it is field, then may be ambiguous?
|
Hey, I know this is a closed issue, but it was not updated in your Go package documentations https://pkg.go.dev/github.com/consensys/gnark#section-readme. Specifically, the first example given of a cubic equation. Would save time for beginners to just add the ecc.BN254.ScalarField() to the example! I had to look around the GitHub for this, which is good practice, but I'd rather save other's time just a little. Thanks for all the hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
frontend.Compilehintswitnessandcspackages dependent on afieldinstead of being dependent on acurveID.This PR adds a
tinyfieldpackage (modulus == 47), for test purposes.I believe the only algorithmic change is
witnessSerialization; instead of usingcurve.Encoderit directly usesfr.Element [Set]Bytes()methods.