Addition of a circuit that checks FRI proximity proofs #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbotrel
requested changes
May 26, 2022
Collaborator
gbotrel
left a comment
gbotrel
left a comment
There was a problem hiding this comment.
need to fix staticcheck errors + would have been nicer to have 3 separate PRs :-)
| circuit.Transfers[i].ReceiverPubKey = circuit.PublicKeysReceiver[i] | ||
|
|
||
| // allocate the slices for the Merkle proofs | ||
| // circuit.allocateSlicesMerkleProofs() |
Collaborator
Author
There was a problem hiding this comment.
Allocating the slices for the Merkle proof is only necessary when creating the full circuit and not for testing sub circuits
| assert := test.NewAssert(t) | ||
|
|
||
| var updateAccountCircuit circuitUpdateAccount | ||
| (*Circuit)(&updateAccountCircuit).allocateSlicesMerkleProofs() |
Collaborator
Author
There was a problem hiding this comment.
type circuitUpdateAccount inherits the fields but not the methods of Circuit
Collaborator
|
👍 just staticcheck linter to fix and is good to merge |
gbotrel
force-pushed
the
feat/fri_verifier_circuit
branch
from
a8db486 to
92c57e6
Compare
Collaborator
|
@ThomasPiellard did a force push on that one, gnark-crypto update was done in another branch 👍 |
gbotrel
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std/commitments/fri/. The verification circuit checks radix-2 fri proximity proof as formatted in gnark-crypto. In particular, Fiat Shamir in gnark-crypto, when used with fri, has been modified so that the challenges seen as string outside a circuit and as frontend.Variable inside of the circuit match.