Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented Jul 29, 2025

Description

This PR fixes the following edge cases:

  • Miller loop computation when G1 point is 0
  • Subgroup membership check for G1 is point is 0

Additionally, it fixes IsOnG1 method which had a typo.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Added corresponding regression tests.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub self-assigned this Jul 29, 2025
@ivokub ivokub added the type: bug Something isn't working label Jul 29, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

YaoJGalteland
YaoJGalteland previously approved these changes Jul 30, 2025
cursor[bot]

This comment was marked as outdated.

@ivokub ivokub requested a review from YaoJGalteland July 30, 2025 13:34
@ivokub ivokub merged commit dfa9af6 into master Jul 30, 2025
7 checks passed
@ivokub ivokub deleted the fix/bls12381-edgecases branch July 30, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants