fix: enable fuzzing for multi-output-hint test by improving dvHint validation #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR. I don't even recall why we disabled multi-output hint test, I think at some point it broke some functionality. I'll have a look at the PR and history and see if we can merge it. |
ivokub
approved these changes
Jun 23, 2025
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
Thanks - short tests seem to pass. I'll merge and see if the long tests also pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue with multi-output-hint test that required disabling fuzzing. Added proper input validation to the dvHint function to handle edge cases during fuzzing and removed the NoFuzzing() option from the integration test.
Fixes # (issue related to multi-output-hint fuzzing)
Type of change
How has this been tested?
Checklist: