feat: implement field emulation over small fields #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivokub
added
type: consolidate
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements field emulation over small fields by replacing legacy API calls (emulated.ValueOf) with the new element constructors (e.g., fp.NewElement, fr.NewElement) and updating schema and witness handling to propagate the underlying field modulus.
- Updated algebra and pairing modules to use the new element constructors.
- Modified schema and witness functions to pass the field modulus, ensuring proper initialization of circuit variables.
- Adjusted tests and CSV statistics to reflect changes for small field support.
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| std/algebra/emulated/sw_bls12381/g2.go | Replaced emulated.ValueOf by fp.NewElement and updated pointer usage. |
| std/algebra/emulated/sw_bls12381/g1.go | Similar API update replacing emulated.ValueOf with ba.NewElement. |
| std/algebra/emulated/fields_bw6761/e6_pairing.go | Updated element constructors to new API in pairing computations. |
| frontend/witness.go, schema/, cs/ | Updated Walk calls to pass the field modulus and propagate field info. |
| internal/smallfields/circuits_test.go | Extended tests for small field compilation and witness initialization. |
| backend/witness/* | Adjusted witness JSON serialization/deserialization to align with new schema parameter. |
ivokub
force-pushed
the
feat/emulation-over-smallfield
branch
from
ae3dc3c to
dbebbe9
Compare
ThomasPiellard
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds capability for the multiplication checks in the field emulation to be performed in small fields. Namely, for the multiplication checks we sample the challenge in field extension and use it instead of a field element.
Depends on #1492, #1493 and #1494. Will rebase after other PRs are merged. For reviewing, have a look at the latest non-merge commits (particularly 1d314a1).
Type of change
How has this been tested?
Added tests to compile and solve (both with actual solver and test engine) over small fields.
Checklist:
golangci-lintdoes not output errors locally