Skip to content

Conversation

@AlexandreBelling
Copy link
Collaborator

Description

In [GetWiresConstraint] and [GetWiresConstraintExact] there is a routine responsible for adding the variable that were not found in the constraints. However, this is done by iterating over a map and the order of insertion of the constraints is non-deterministic.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • Test A
  • Test B

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AlexandreBelling AlexandreBelling added the type: bug Something isn't working label Apr 30, 2025
@AlexandreBelling AlexandreBelling self-assigned this Apr 30, 2025
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivokub ivokub merged commit a3c39fa into master May 6, 2025
5 checks passed
@ivokub ivokub deleted the prover/make-get-wire-deterministic branch May 6, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants