feat: map to g2 on BLS12-381 #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pectra/precompiles
…pectra/precompiles
Contributor
There was a problem hiding this comment.
Copilot reviewed 34 out of 36 changed files in this pull request and generated no comments.
Files not reviewed (2)
- go.mod: Language not supported
- internal/stats/latest_stats.csv: Language not supported
Comments suppressed due to low confidence (3)
std/algebra/emulated/sw_bls12381/g2_test.go:227
- Verify that the scalar field used in tests (ecc.BN254.ScalarField()) is appropriate for BLS12-381 operations, as an inadvertent mismatch might lead to subtle errors during verification.
err := test.IsSolved(&MultiScalarMulTest{}, &assignment, ecc.BN254.ScalarField())
std/algebra/emulated/sw_bls12381/g1.go:190
- [nitpick] Consider clarifying the subgroup order check within AssertIsOnG1 with additional inline comments to improve maintainability and ease future reviews.
func (g1 *G1) AssertIsOnG1(P *G1Affine) {
std/algebra/emulated/sw_bls12381/hints.go:345
- [nitpick] Consider clarifying the function comment regarding the expected order of nativeOutputs in g1SqrtRatioHint to ensure maintainers understand the intended behavior.
func g1SqrtRatioHint(nativeMod *big.Int, nativeInputs, nativeOutputs []*big.Int) error {
ThomasPiellard
approved these changes
Apr 16, 2025
AlexandreBelling
pushed a commit
that referenced
this pull request
Apr 30, 2025
Co-authored-by: Youssef El Housni <[email protected]> Co-authored-by: Thomas Piellard <[email protected]> Co-authored-by: Arya Tabaie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit cherry-picks only map-to-g2 from #1473. Depends on #1447.
Hash-to-G2 will be worked on in #1473 as requires some modification in other gadgets which could be pushed separately.
Type of change
How has this been tested?
Checklist:
golangci-lintdoes not output errors locally