fix: do not return unused sign #1385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the fake GLV method we return the sign, but it is not used in the point. Due to the hint calling abstraction for non-native computation we still range check the variables. It is unoptimal, but in Linea prover we explicitly check if the variables are used in sequential constraints. As we don't, then this leads to compile error.
However, we still use the fifth output in BLS12-377, so no change there.
@yelhousni - can you double check that we haven't previously added unsoundness due to unused variable?
Type of change
How has this been tested?
All existing tests succeed.
How has this been benchmarked?
Updated stats - saves a bit more than 100 constraints for scalar multiplication
Checklist:
golangci-lintdoes not output errors locally