optim: avoid div in millerLoopAndFinalExpResult #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
cc @yelhousni , see also #1347 (reply in thread) |
yelhousni
approved these changes
Dec 19, 2024
Contributor
yelhousni
left a comment
yelhousni
left a comment
There was a problem hiding this comment.
Thanks for spotting it 👍
Indeed it saves 1585 scs corresponding to the equality check in the hinted DivUnchecked.
lucasmenendez
pushed a commit
to lucasmenendez/gnark
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Super minor optimisation to replace a div with a mul, for exponentiation by
λ' = q^3 - q^2 + q. We already have the inv so we can just exp the inverse byq^2and mul (instead of exp and div).How has this been tested?