Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented Dec 17, 2024

Description

gnark-crypto changed APIs for generating field implementation. Additionally Consensys/gnark-crypto#577 also forces uint32 element generation only for baby and koala bear fields. Now tinyfield implementation is still compatible with the previous constraint.Element definition ([6]uint64).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the type: dependencies Pull requests that update a dependency file label Dec 17, 2024
@ivokub ivokub self-assigned this Dec 17, 2024
@ThomasPiellard ThomasPiellard merged commit 1f944e8 into master Dec 17, 2024
4 checks passed
@ThomasPiellard ThomasPiellard deleted the fix/tinyfield-gen branch December 17, 2024 13:39
lucasmenendez pushed a commit to lucasmenendez/gnark that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants