Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented Sep 3, 2024

Description

Previously the Groth16 interfaces referred to groth16Object. As it wasn't exported, then it wasn't obvious that the interfaces implement the IO methods. I made the methods now explicit for better reference.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: consolidate strengthen an existing feature type: doc labels Sep 3, 2024
@ivokub ivokub requested a review from gbotrel September 3, 2024 12:24
@ivokub ivokub self-assigned this Sep 3, 2024
@ivokub ivokub merged commit 8b00519 into master Sep 3, 2024
@ivokub ivokub deleted the chore/io-interfaces branch September 3, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: consolidate strengthen an existing feature type: doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants