Skip to content

Conversation

@Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Aug 16, 2024

This PR updates the Groth16 BSB22 Commitments module to match recent gnark-crypto changes.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabaie Tabaie requested a review from yelhousni August 16, 2024 18:17
@Tabaie Tabaie marked this pull request as ready for review August 17, 2024 17:44
Copy link
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yelhousni yelhousni merged commit 841a46e into master Aug 20, 2024
@yelhousni yelhousni deleted the build/bump-gnarkcrypto-vsn branch August 20, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants