Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented Jul 18, 2024

Description

Previously, we only checked if the variable to be range checked externally was at L xor R locations in the gate. In this PR we remove the restrictions that we can use a gate only a single variable range check. Additionally, we also output now if the variable is in the O location in the gate.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

In downstream usage

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: consolidate strengthen an existing feature dep: linea Issues affecting Linea downstream labels Jul 18, 2024
@ivokub ivokub requested a review from AlexandreBelling July 18, 2024 11:12
@ivokub ivokub self-assigned this Jul 18, 2024
@ivokub ivokub merged commit c2da0b0 into master Jul 18, 2024
@ivokub ivokub deleted the feat/ext-range-checker-o branch July 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting Linea downstream type: consolidate strengthen an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants