Skip to content

Conversation

@AlexandreBelling
Copy link
Collaborator

Description

The PR allows the caller of ExpMod to specify which field parameter to use for the circuit generation as the current implemenentation fixes a size of 4096.

The PR also adds the 256 bit variant of Mod1e512

This is required for the integration in the prover.

The changes did not break existing calling code.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

No test have been added specifically for the changes

How has this been benchmarked?

No benchmark have been done.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivokub ivokub added the dep: linea Issues affecting Linea downstream label Jun 28, 2024
@ivokub ivokub merged commit 9c41095 into master Jun 28, 2024
@ivokub ivokub deleted the modexp/with-parametrizable-emulated-field branch June 28, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting Linea downstream type: new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants