Skip to content

Conversation

@ThomasPiellard
Copy link
Collaborator

Description

An option is added in ExportSolidity to add some solidity specific parameters, like the solc version. The signature is now
func (vk *VerifyingKey) ExportSolidity(w io.Writer, exportOpts ...solidity.ExportOption) error

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Same test suite as before

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard requested review from gbotrel and ivokub and removed request for ivokub May 21, 2024 16:32
@gbotrel gbotrel self-requested a review May 31, 2024 13:56
@ThomasPiellard ThomasPiellard merged commit 02d4678 into master Jun 3, 2024
@ThomasPiellard ThomasPiellard deleted the feat/option_solidity branch June 3, 2024 16:21
@ivokub ivokub mentioned this pull request Jul 3, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants