Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented May 9, 2024

Description

When extracting the constraint indices for range checking, we didn't take into account the added constraints rows in the traces which account for the public inputs. We now shift the constraint indices by the number of public variables.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

In zkevm repo.

How has this been benchmarked?

Not benchmarked. But added an optimization to break the loop early when all results have been found.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added type: bug Something isn't working dep: linea Issues affecting Linea downstream priority: P1-high Issue priority: high labels May 9, 2024
@ivokub ivokub requested a review from gbotrel May 9, 2024 09:04
@ivokub ivokub self-assigned this May 9, 2024
@ivokub ivokub merged commit e822c15 into master May 14, 2024
@ivokub ivokub deleted the fix/extrangecheck-pubshift branch May 14, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dep: linea Issues affecting Linea downstream priority: P1-high Issue priority: high type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants