Skip to content

Conversation

@ivokub
Copy link
Collaborator

@ivokub ivokub commented Jan 15, 2024

Description

It is not mentioned that inputs and outputs are already initialized and the user shouldn't leak the value. Clarified a bit.

Related: #998

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How has this been tested?

Not tested

How has this been benchmarked?

Not benchmarked.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from gbotrel January 15, 2024 13:43
@ivokub ivokub self-assigned this Jan 15, 2024
@gbotrel gbotrel merged commit aa1dc4e into master Jan 22, 2024
@gbotrel gbotrel deleted the docs/hint-api branch January 22, 2024 19:20
lighterabc pushed a commit to lighterabc/gnark that referenced this pull request Jan 23, 2024
lighterabc pushed a commit to lighterabc/gnark that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants