Repository navigation
Commit da50c34
authored
fix(arborist): reject uninstall args that carry a version (npm#9881)
## What / Why
`npm uninstall [email protected]` neither removes the package nor complains
about the argument. The spec goes straight through to Arborist as an
`rm` entry, nothing in the tree is named `[email protected]`, so the reify
finishes with "up to date" and `npm ls` still shows `vite`.
`npm update` already validates its own argument list and throws
`EUPDATEARGS` for anything that is not a bare package name. This applies
the same rule to `rm`, so a version, tag or range now fails with
`ERMARGS` and the message names the command to run instead.
## Testing
New case in `workspaces/arborist/test/arborist/build-ideal-tree.js`,
next to the existing rm test and mirroring the update one. It covers an
exact version, a tag, ranges, a scoped name carrying a version, and a
filesystem path, where the suggestion falls back to `<pkg>` because
there is no name to print. It fails without the change.
## References
Fixes npm#98801 parent 71915e8 commit da50c34
3 files changed
Lines changed: 85 additions & 0 deletions
File tree
- test/lib/commands
- workspaces/arborist
- lib/arborist
- test/arborist
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
146 | 174 | | |
147 | 175 | | |
148 | 176 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
400 | 416 | | |
401 | 417 | | |
402 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2347 | 2347 | | |
2348 | 2348 | | |
2349 | 2349 | | |
| 2350 | + | |
| 2351 | + | |
| 2352 | + | |
| 2353 | + | |
| 2354 | + | |
| 2355 | + | |
| 2356 | + | |
| 2357 | + | |
| 2358 | + | |
| 2359 | + | |
| 2360 | + | |
| 2361 | + | |
| 2362 | + | |
| 2363 | + | |
| 2364 | + | |
| 2365 | + | |
| 2366 | + | |
| 2367 | + | |
| 2368 | + | |
| 2369 | + | |
| 2370 | + | |
| 2371 | + | |
| 2372 | + | |
| 2373 | + | |
| 2374 | + | |
| 2375 | + | |
| 2376 | + | |
| 2377 | + | |
| 2378 | + | |
| 2379 | + | |
| 2380 | + | |
| 2381 | + | |
| 2382 | + | |
| 2383 | + | |
| 2384 | + | |
| 2385 | + | |
| 2386 | + | |
| 2387 | + | |
| 2388 | + | |
| 2389 | + | |
| 2390 | + | |
2350 | 2391 | | |
2351 | 2392 | | |
2352 | 2393 | | |
| |||
0 commit comments