Skip to content

Conversation

@JafarAz
Copy link
Contributor

@JafarAz JafarAz commented Mar 28, 2024

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

Copy link
Contributor

@0xBrainjar2 0xBrainjar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the definitions related to mantis and cows etc to the other docs, not picasso

@JafarAz JafarAz changed the title docs(migration): revamp docs for picasso dedicated docuementation docs(migration): revamp docs for picasso dedicated docs Mar 28, 2024
@github-actions
Copy link

github-actions bot commented Apr 2, 2024

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Apr 2, 2024
@JafarAz JafarAz requested a review from 0xBrainjar2 April 3, 2024 05:50
@blasrodri blasrodri enabled auto-merge April 3, 2024 13:15
@blasrodri blasrodri merged commit 6aa77b3 into main Apr 3, 2024
@blasrodri blasrodri deleted the docs-revamp-1 branch April 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale-item bot: Stale PRs and issues handling #owned:terraform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants