Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@dzmitry-lahoda dzmitry-lahoda changed the title feat(devent): mantis running feat(devnet): mantis running locally and remotely Dec 12, 2023
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review December 12, 2023 19:00
@dzmitry-lahoda dzmitry-lahoda requested a review from kkast December 12, 2023 19:31
@dzmitry-lahoda dzmitry-lahoda merged commit 9a9846a into main Dec 12, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/c/6 branch December 12, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants