feat(xcvm): use Displayed consistently for large integers #4073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
added
the
Misc
Pull reviewers statsStats of the last 30 days for composable:
|
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4073/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4073/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4073/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # run cross chain devnet with Dotsama and Cosmos nodes
nix run "github:ComposableFi/composable/refs/pull/4073/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4073/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh |
dzmitry-lahoda
previously approved these changes
Aug 15, 2023
dzmitry-lahoda
approved these changes
Aug 15, 2023
Contributor
|
from Into u128? because uXxx and Uxxx, all do it. same for u64. i guess it may work no macro. |
Contributor
Author
|
cosmwasm uses explicit definitions for Uint128, see https://docs.rs/cosmwasm-std/latest/src/cosmwasm_std/math/uint128.rs.html#273. If there is some way to make derive_macro or something else work, I certainly don’t see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For data structures which are part of public API consistently use
Dispalyed wrapper for u128 and u64 integers. This is to make sure
that the numbers are encoded as strings when serialising to JSON.
This doesn’t change anything right now but future upgrades of
serde-json-wasm will change how integers are serialised so this is
future-proofing the code.
While at it, since Displayed is a shared wrapper used by various
modules, move it to shared module rather than keeping it in asset.
Required for merge:
pr-workflow-check / draft-release-checkis ✅ successMakes review faster:
misclabel if it should not be in release notesReviewers@) or used other form of notification of one person who I think can handle best review of this PR