Skip to content

Conversation

@mina86
Copy link
Contributor

@mina86 mina86 commented Aug 14, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@mina86 mina86 requested a review from blasrodri August 14, 2023 18:00
@mina86 mina86 enabled auto-merge August 14, 2023 18:00
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 25 12h 34m 19
blasrodri 18 1h 58m 11
RustNinja 16 1h 11m 2
mina86 15 1d 37m 82
kkast 12 3h 53m 7
vmarkushin 3 7h 2
JafarAz 3 9h 25m 0
0xBrainjar2 1 3d 17h 35m 6

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4068/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4068/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4068/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4068/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4068/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

blasrodri
blasrodri previously approved these changes Aug 14, 2023
Copy link
Contributor

@blasrodri blasrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better! Thanks :)

@mina86 mina86 changed the title doc(pallet-assets-registry): document generate_asset_id docs(pallet-assets-registry): document generate_asset_id Aug 14, 2023
dzmitry-lahoda
dzmitry-lahoda previously approved these changes Aug 15, 2023
@mina86
Copy link
Contributor Author

mina86 commented Aug 15, 2023

@blasrodri, @dzmitry-lahoda, PTAL

@mina86
Copy link
Contributor Author

mina86 commented Aug 15, 2023

Friendly ping.

@mina86 mina86 added this pull request to the merge queue Aug 15, 2023
Merged via the queue into main with commit 25eda0d Aug 15, 2023
@mina86 mina86 deleted the mpn/b branch August 15, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants