Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Aug 10, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@dzmitry-lahoda dzmitry-lahoda changed the title feat(cw-ibc): logging for transfer feat(cw-ibc): logging for transfer and storage lookup Aug 10, 2023
@dzmitry-lahoda dzmitry-lahoda changed the title feat(cw-ibc): logging for transfer and storage lookup feat(cw-ibc): logging for transfer and storage query Aug 10, 2023
@dzmitry-lahoda dzmitry-lahoda changed the title feat(cw-ibc): logging for transfer and storage query feat(cw-ibc): prefixed logging for transfer and query for routes Aug 10, 2023
@dzmitry-lahoda dzmitry-lahoda requested a review from mina86 August 10, 2023 16:49
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review August 10, 2023 16:50
@dzmitry-lahoda dzmitry-lahoda added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Aug 10, 2023
@dzmitry-lahoda dzmitry-lahoda added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 53656a2 Aug 10, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/313 branch August 10, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants