Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Aug 7, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review August 7, 2023 18:28
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 20 12h 53m 20
RustNinja 19 1h 50m 2
blasrodri 16 2h 33m 13
mina86 9 14h 42m 64
kkast 9 11h 52m 4
vmarkushin 1 1h 6m 0
josietyleung 1 1d 20h 28m 3
JafarAz 1 9h 25m 0

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4032/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4032/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4032/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4032/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4032/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Aug 7, 2023
@dzmitry-lahoda dzmitry-lahoda changed the title ci(devnet): run dotsama only in tests ci(devnet): run dotsama only in tests (full devnet minus hermes/osmosis) Aug 7, 2023
@kkast kkast disabled auto-merge August 7, 2023 18:48
@kkast
Copy link
Contributor

kkast commented Aug 7, 2023

lets wait for new pr if it passes old ci checks, then we will merge this since it changes cis also

Copy link
Contributor

@kkast kkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will approve after see that old ci fails or passes.

@dzmitry-lahoda
Copy link
Contributor Author

evidently old ci passes.

@kkast
Copy link
Contributor

kkast commented Aug 7, 2023

now it passes. before this commit it wasnt df0b54e. lets still merge this since osmosis build shouldnt affect our tests

Signed-off-by: dzmitry-lahoda <[email protected]>
@dzmitry-lahoda dzmitry-lahoda requested a review from kkast August 7, 2023 20:04
@dzmitry-lahoda dzmitry-lahoda changed the title ci(devnet): run dotsama only in tests (full devnet minus hermes/osmosis) ci(devnet): dotsama devenet package (full devnet minus hermes/osmosis) Aug 7, 2023
@dzmitry-lahoda dzmitry-lahoda added this pull request to the merge queue Aug 7, 2023
@RustNinja RustNinja self-requested a review August 7, 2023 21:16
Merged via the queue into main with commit 4cdd338 Aug 7, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/666 branch August 7, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants