Skip to content

Conversation

@JafarAz
Copy link
Contributor

@JafarAz JafarAz commented Aug 4, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@JafarAz JafarAz added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Aug 4, 2023
@JafarAz JafarAz requested a review from kkast August 4, 2023 14:12
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
RustNinja 19 1h 50m 2
dzmitry-lahoda 18 21h 38m 27
blasrodri 13 8h 8m 13
mina86 8 12h 56m 64
kkast 7 22h 12m 4
vmarkushin 2 6d 10h 24m 3
josietyleung 1 1d 20h 28m 3

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4018/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4018/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4018/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4018/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4018/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda
Copy link
Contributor

@JafarAz please do docs(assets): added well known composable assets,

so same CI will tell you to do.

@dzmitry-lahoda
Copy link
Contributor

if you will name your commits like that it will become PR title automatically

image

@JafarAz JafarAz changed the title Add Asset list to docs docs(assets): added well known composable assets Aug 4, 2023
@dzmitry-lahoda
Copy link
Contributor

@JafarAz please rebase on latest main.

@dzmitry-lahoda
Copy link
Contributor

new gate was added, but your branch cannot pass that gate as has old broken things

@JafarAz JafarAz added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit 6ff0ae8 Aug 8, 2023
@JafarAz JafarAz deleted the asset-list branch August 8, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants