Added key names to Sizer controls to make it possible to override the styles #717
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
changed the title
Member
|
Thanks @0x5bfa, we're usually pretty good about this pattern for Toolkit controls, but this is a bit odder case with the inheritance from a common style. Appreciate you taking a look into it! 🦙❤️ @Arlodotexe I did a quick pass, I think it all looks good. Mind doing a functional test of the changes? I think we have some basic loading tests for these, but we don't do much with the visuals. |
…r constructors, move constructor
Arlodotexe
approved these changes
Oct 6, 2025
zubinqayam
approved these changes
Dec 4, 2025
Member
|
Held up by #758 |
michael-hawker
approved these changes
Dec 10, 2025
Member
|
UWP branch had failed, not sure why... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Added key names to the Sizer controls so you override the styles of the Sizer controls.
PR Type
What is the current behavior?
You cannot override unless you copy and paste the style of SizerBase. The three deriviative controls even didn't have their own styles. And you couldn't create a style for one of them because all of them didn't set
DefaultKeyStyleproperty.What is the new behavior?
Being able to override.
PR Checklist
Other information
I've tested this change in the sample app & with the Sizer tests on my local.