Skip to content

Fix IsNullOrEmptyStateTrigger for Uno to consider FEs as non-empty #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Arlodotexe merged 3 commits into from
Jul 9, 2024
Merged

Fix IsNullOrEmptyStateTrigger for Uno to consider FEs as non-empty #452

Arlodotexe merged 3 commits into from
Jul 9, 2024

Conversation

@Youssef1313
Copy link
Contributor

@Youssef1313 Youssef1313 commented Jul 9, 2024

Fixes

Fixes unoplatform/uno#17311

PR Type

What kind of change does this PR introduce?

What is the current behavior?

FrameworkElements in Uno are incorrectly IEnumerables, so they could be considered as empty incorrectly.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@Arlodotexe Arlodotexe self-requested a review July 9, 2024 17:30
Arlodotexe
Arlodotexe approved these changes Jul 9, 2024
View reviewed changes
@Arlodotexe
Copy link
Member

Arlodotexe commented Jul 9, 2024

Thanks for the contribution @Youssef1313, I've added tracking details in a code comment so we can cleanup the workaround once the regression is fixed.

@Arlodotexe
Copy link
Member

Arlodotexe commented Jul 9, 2024 •
edited
Loading

Seems these changes don't build as expected, here's the compiler error from CI:

         /home/runner/work/Windows/Windows/components/Triggers/src/IsNullOrEmptyStateTrigger.cs(121,32): error CS0128: A local variable or function named 'valEnumerable' is already defined in this scope [/home/runner/work/Windows/Windows/components/Triggers/src/CommunityToolkit.WinUI.Triggers.csproj::TargetFramework=net8.0]
         /home/runner/work/Windows/Windows/components/Triggers/src/IsNullOrEmptyStateTrigger.cs(127,34): error CS8602: Dereference of a possibly null reference. [/home/runner/work/Windows/Windows/components/Triggers/src/CommunityToolkit.WinUI.Triggers.csproj::TargetFramework=net8.0]

@Arlodotexe Arlodotexe enabled auto-merge (squash) July 9, 2024 18:23
@agneszitte
Copy link

agneszitte commented Jul 9, 2024

Thank you for the review @Arlodotexe!

@agneszitte
Copy link

agneszitte commented Jul 9, 2024 •
edited
Loading

@Arlodotexe, @Youssef1313 it seems that some tests are failing

@Youssef1313
Copy link
Contributor Author

Youssef1313 commented Jul 9, 2024

The failure looks unrelated to the change

@Arlodotexe Arlodotexe merged commit 815d629 into CommunityToolkit:main Jul 9, 2024
@Youssef1313 Youssef1313 deleted the patch-1 branch July 9, 2024 20:45
This was referenced Jul 10, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SettingsCard does not render content

3 participants

@Youssef1313 @Arlodotexe @agneszitte