Skip to content

Segmented - Update EqualPanel to avoid Layout Cycle #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Arlodotexe merged 2 commits into from
Mar 22, 2024
Merged

Segmented - Update EqualPanel to avoid Layout Cycle #360

Arlodotexe merged 2 commits into from
Mar 22, 2024

Conversation

@qhy040404
Copy link
Contributor

@qhy040404 qhy040404 commented Mar 6, 2024

Fixes #359

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

LayoutCycleException will be thrown at specific screen scaling ( #359 )

What is the new behavior?

The Segmented can be correctly layout.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ x ] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [ x ] Based off latest main branch of toolkit
  • [ x ] Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • [ x ] Contains NO breaking changes

Other information

@qhy040404
Copy link
Contributor Author

qhy040404 commented Mar 6, 2024

@dotnet-policy-service agree

@niels9001 niels9001 requested a review from Arlodotexe March 9, 2024 14:22
@qhy040404
Copy link
Contributor Author

qhy040404 commented Mar 9, 2024

sorry for my typo :(

@niels9001 niels9001 self-requested a review March 19, 2024 18:06
@michael-hawker michael-hawker added this to the 8.1 milestone Mar 19, 2024
@Arlodotexe Arlodotexe merged commit bf06874 into CommunityToolkit:main Mar 22, 2024
@qhy040404 qhy040404 deleted the patch-1 branch March 22, 2024 14:18
@dhoehna
Copy link

dhoehna commented Apr 2, 2024

Any idea when this'll be in a nuget package? DevHome is currently facing this issue.

@dhoehna dhoehna mentioned this pull request Apr 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@niels9001 niels9001 niels9001 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.1

Development

Successfully merging this pull request may close these issues.

Segmented - Layout Cycle at specific screen scaling

5 participants

@qhy040404 @dhoehna @Arlodotexe @niels9001 @michael-hawker