Porting TabbedCommandBar #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
reviewed
Jan 16, 2024
components/TabbedCommandBar/src/CommunityToolkit.WinUI.Controls.TabbedCommandBar.csproj
Show resolved
Hide resolved
…s.TabbedCommandBar.csproj Co-authored-by: Arlo <[email protected]>
Member
|
@niels9001 Looks like TabbedCommandBar isn't appearing on Wasm. The browser console shows the exception and call stack: |
Member
|
Looks like we should be ensuring to use the WinUI 2 MUX versions of controls everywhere vs. old WUX ones. |
Member
|
Latest on Wasm - In TabbedCommandBar, text is missing on the tabs and the cause is less clear. No errors in the console.
|
Member
|
I've moved the Wasm issue to a new ticket. We can close this PR once #320 closes and unblocks our CI. |
michael-hawker
approved these changes
Jan 30, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings
TabbedCommandBarfrom the old repository.Changes:
The new styling mimics the styling found in the Office apps:
Closes: #93