Fixed an issue where all documents were include regardless of MultiTarget support #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
changed the title
Member
|
I may have to try another machine, I haven't been able to get past unoplatform/Uno.Wasm.Bootstrap#776 building this at the moment. |
Member
|
@Arlodotexe tested this against the latest changes in the CommunityToolkit/Tooling-Windows-Submodule#141 PR that this is on top of, this PR needs to be updated though, but otherwise, good to go. |
michael-hawker
approved these changes
Oct 3, 2023
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Tested this earlier with the submodule changes, so should be all good, thanks!
delete-merged-branch
bot
deleted the
fix/samples/multitarget-aware-sample-docs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fixes an issue where all documents were include regardless of MultiTarget support.
What is the current behavior?
Before, the tooling would blindly pull in all markdown files and let the SampleGen source generator sort it out for creating the Document Registry.
This is in contrast to the Sample Registry, which inherits its MultiTarget-aware characteristics from MSBuild by discovering only in projects that are referenced at build time.
What is the new behavior?
With these changes, markdown files are preprocessed with the new Target. Files found in components that don't
<MultiTarget>the platform being built are filtered out before being added asAdditionalFiles. Then, it's picked up by the SampleGen tooling to create the Document Registry.PR Checklist
Please check if your PR fulfills the following requirements:
Other information