Skip to content

Update Uno version, Uno TFMs to .NET 8 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michael-hawker merged 10 commits into from
Jun 4, 2024
Merged

Update Uno version, Uno TFMs to .NET 8 #191

michael-hawker merged 10 commits into from
Jun 4, 2024

Conversation

@Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented May 17, 2024

This PR:

Arlodotexe
Arlodotexe commented May 17, 2024
View reviewed changes
Copy link
Member Author

@Arlodotexe Arlodotexe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened as a draft. We're seeing linker issues when compiling release mode. Tested against the main repo by running this command:

.\tooling\Build-Toolkit-Gallery.ps1 -Head wasm -MultiTargets wasm -Components All -WinUIMajorVersion 2 -Release

We see this error message with no additional details:

C:\Users\arlog\.nuget\packages\uno.wasm.bootstrap\7.0.29\build\Uno.Wasm.Bootstrap.targets(206,3): error : System.Exception: Failed to exe 
       cute the linker [C:\Users\arlog\source\repos\Windows\tooling\ProjectHeads\AllComponents\wasm\CommunityToolkit.App.Wasm.csproj]

This error is also showing in the CI.

@Arlodotexe Arlodotexe mentioned this pull request May 17, 2024
Merged
@Arlodotexe Arlodotexe self-assigned this May 17, 2024
@Arlodotexe Arlodotexe marked this pull request as ready for review May 21, 2024 15:31
@Arlodotexe Arlodotexe requested a review from michael-hawker May 21, 2024 15:32
@Arlodotexe
Copy link
Member Author

Arlodotexe commented May 21, 2024

Thanks @jeromelaban for the help!

For reference, the issue was that the Uno.Wasm.Bootstrap package version doesn't align with Uno.UI/Uno.WinUI/etc. via our CommonUnoPackageVersion property and had to be updated separately. We'll need to keep this in mind for future updates. Unfortunately, we can't make use of the Uno SDK to keep things in step because it doesn't support UWP.

We should be able to close this off and include the changes in the 8.1 update.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) May 21, 2024 22:44
michael-hawker
michael-hawker previously approved these changes May 30, 2024
View reviewed changes
auto-merge was automatically disabled May 30, 2024 18:42

Rebase failed

@michael-hawker
Copy link
Member

michael-hawker commented May 30, 2024

May want to look at the 422 equivalent as there's an Android error there:

error NETSDK1181: Error getting pack version: Pack 'Microsoft.Android.Ref.33' was not present in workload manifests. [C:\a\Windows\Windows\components\Triggers\samples\Triggers.Samples.csproj::TargetFramework=net8.0-android33.0]

@michael-hawker michael-hawker dismissed their stale review May 30, 2024 18:46

Build error in linked 422

@jeromelaban
Copy link
Contributor

jeromelaban commented May 30, 2024

May want to look at the 422 equivalent as there's an Android error there:

This generally happens when the TargetPlatformVersion is 33 instead of 34 (which net8 targets).

@Arlodotexe
Copy link
Member Author

Arlodotexe commented May 30, 2024

Thanks Jerome, I'll give that a try. Found additional information on this error message here.

@Arlodotexe Arlodotexe enabled auto-merge (rebase) May 30, 2024 19:55
auto-merge was automatically disabled June 4, 2024 21:28

Rebase failed

@michael-hawker michael-hawker merged commit e366657 into main Jun 4, 2024
@delete-merged-branch delete-merged-branch bot deleted the uno/net8 branch June 4, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels

None yet

Projects

Toolkit 8.x
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Uno Platform library TFMs to net8.0

3 participants

@Arlodotexe @michael-hawker @jeromelaban