Skip to content

Fix CI failure after update to PowerShell 7.4.0 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Arlodotexe merged 2 commits into from
Jan 31, 2024
Merged

Fix CI failure after update to PowerShell 7.4.0 #167

Arlodotexe merged 2 commits into from
Jan 31, 2024

Conversation

@Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jan 30, 2024

Closes #166

This fixes the CI failures that started to occur after the latest GitHub Actions image update, which updated PowerShell to 7.4.0 LTS by default for ubuntu-22.04.

@Arlodotexe Arlodotexe self-assigned this Jan 30, 2024
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jan 31, 2024

We're getting a different error now:

Build started 01/30/[20](https://github.com/CommunityToolkit/Tooling-Windows-Submodule/actions/runs/7718544835/job/21040059522?pr=167#step:9:21)24 22:59:59.
SlnGen : error : Unhandled exception: System.ArgumentException: The value cannot be an empty string. (Parameter 'path')
SlnGen : error :    at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
SlnGen : error :    at System.IO.Path.GetFullPath(String path)
SlnGen : error :    at System.Linq.Enumerable.SelectEnumerableIterator`2.MoveNext()

The first error could be reproduced locally, but not this one. @michael-hawker any ideas what it could be?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jan 31, 2024

Looks like that did the trick 🎉

@Arlodotexe Arlodotexe changed the title Fixed syntax error under PowerShell 7.4.0 Fix CI failure after update to PowerShell 7.4.0 Jan 31, 2024
@Arlodotexe Arlodotexe enabled auto-merge (rebase) January 31, 2024 18:28
@Arlodotexe Arlodotexe merged commit 03d01be into main Jan 31, 2024
@delete-merged-branch delete-merged-branch bot deleted the fix/ci/pwsh/7.4.0 branch January 31, 2024 20:16
This was referenced Jan 31, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels

None yet

Projects

Toolkit 8.x
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI failing after Actions upgrade to pwsh 7.4.0

2 participants

@Arlodotexe @michael-hawker