Postpone popup show until platform is ready#934
Merged
Conversation
bijington
requested review from
TheCodeTraveler,
VladislavAntonyuk,
jfversluis and
pictos
1 task
pictos
suggested changes
Jan 26, 2023
Member
pictos
left a comment
pictos
left a comment
There was a problem hiding this comment.
@bijington thanks for it! This's a huge improvement. I've some suggestions
… of github.com:CommunityToolkit/Maui into feature/sl/postpone-popup-show-until-platform-is-ready
Contributor
Author
Great points! I should have addressed those now 👍 |
pictos
reviewed
Jan 26, 2023
Co-authored-by: Pedro Jesus <[email protected]>
pictos
approved these changes
Jan 27, 2023
pictos
deleted the
feature/sl/postpone-popup-show-until-platform-is-ready
branch
|
Fantastic! When's the next preview release coming? |
Member
|
@symbiogenesis we don't have a time right now |
This was referenced Jan 29, 2023
Closed
1 task
2 tasks
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Introduces the approach of deferring a
ShowPopupandShowPopupAsynccall to theOnNavigatedToevent if theIsPlatformEnabledflag isfalse. This matches how .NET MAUI provides similar support for things likeDisplayAlert, etc.Linked Issues
Possibly helps
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information