Add popup sizing page to cover more test scenarios#1770
Add popup sizing page to cover more test scenarios#1770TheCodeTraveler merged 7 commits intomainfrom
Conversation
|
The only suggestion to move all Popup to another section/group. We already have a page with many buttons to show different popups, maybe it make sense to move all samples related to popup to the page |
Oh yeah that's a great idea |
There was a problem hiding this comment.
Great idea Shaun!!
It looks like the HorizontalStackLayout and VerticalStackLayout has an issue on the new PopupSizingIssuesPage, but since that bug isn't caused by this PR I'm good to merge this 👍
@cat0363 - as our resident Popup expert, any chance you're familiar with these Popup sizing/layout bugs?
| HorizontalStackLayout | VerticalStackLayout | Border |
|---|---|---|
![]() |
![]() |
![]() |



Description of Change
This PR doesn't aim to fix anything, its purpose is to provide a more comprehensive set of
Popupbased samples to make verification of change/fixes easier.The current approach relies on a bit of magic:
And it is driven from a list of
Containers:I couldn't decide whether this saved on effort over a single clearly defined scenario e.g.
The part I really like is the effort we save by not having to create a popup xaml/c# for each scenario.
Thoughts?
Linked Issues
n/a
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information