Skip to content

Remove the old code to set the status bar behavior values#1713

Merged
jfversluis merged 3 commits intomainfrom
feature/sl-remove-conflicting-statusbar-code
Feb 26, 2024
Merged

Remove the old code to set the status bar behavior values#1713
jfversluis merged 3 commits intomainfrom
feature/sl-remove-conflicting-statusbar-code

Conversation

@bijington
Copy link
Copy Markdown
Contributor

This might not be completely necessary as it doesn't currently conflicting with our samples page but... the code removed here does conflict if a developer opts for just providing a value into the StatusBarBehavior (e.g.

<Page.Behaviors>
        <mct:StatusBarBehavior
              StatusBarColor="Red"
              StatusBarStyle="{Binding Source={x:Reference Page}, Path=BindingContext.StatusBarStyle}" />
 </Page.Behaviors>

The resulting behaviour will be that no Color will exist and the status bar (at least on iOS) will be Black.

@bijington bijington requested a review from a team February 25, 2024 14:10
@jfversluis jfversluis merged commit 739c843 into main Feb 26, 2024
@jfversluis jfversluis deleted the feature/sl-remove-conflicting-statusbar-code branch February 26, 2024 12:44
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants