Fixed issue with tinted image size being set incorrectly on Windows.#1685
Merged
TheCodeTraveler merged 11 commits intoCommunityToolkit:mainfrom Feb 17, 2024
Merged
Fixed issue with tinted image size being set incorrectly on Windows.#1685TheCodeTraveler merged 11 commits intoCommunityToolkit:mainfrom
TheCodeTraveler merged 11 commits intoCommunityToolkit:mainfrom
Conversation
Contributor
Author
@dotnet-policy-service agree |
pictos
reviewed
Feb 13, 2024
Contributor
|
I think we have some versioning issues which a current PR I hoping to fix. Then the checks might be happy again |
StevilKnevil
changed the title
pictos
reviewed
Feb 16, 2024
Co-authored-by: Pedro Jesus <[email protected]>
TheCodeTraveler
approved these changes
Feb 17, 2024
Collaborator
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks @StevilKnevil!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Tinted images now have their base images set to transparent rather than zero size.
I have been unable to add a unit test for this as I cannot work out how to trigger an update of the tint colour in the context of a test.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR