Add SystemNavigationBar behavior for android#1665
Add SystemNavigationBar behavior for android#1665tranb3r wants to merge 2 commits intoCommunityToolkit:mainfrom tranb3r:feature-navbar
Conversation
pictos
left a comment
pictos
left a comment
There was a problem hiding this comment.
Thanks for your PR. I would that your implement isn't the best solution for this, since we're talking about a feature that will be available just for one platform, doesn't make sense to expose it in a multi-target way and throw exceptions on other platforms. I added some references on how you can approach this.
if you have more questions about the API implementation, let's use the issue to discuss it.
| } | ||
| } | ||
|
|
||
| static bool IsSupported() |
There was a problem hiding this comment.
Can you cache this value? I doubt this value will change during the app runtime.
| /// <see cref="PlatformBehavior{TView,TPlatformView}"/> that controls the System navigation bar color | ||
| /// </summary> | ||
| [UnsupportedOSPlatform("Windows"), UnsupportedOSPlatform("MacCatalyst"), UnsupportedOSPlatform("MacOS"), UnsupportedOSPlatform("Tizen"), UnsupportedOSPlatform("iOS")] | ||
| public class SystemNavigationBarBehavior : PlatformBehavior<Page> |
There was a problem hiding this comment.
Since this is a platform-specific just for Android, I don't think this is the best way to do it. You should use the OnPlatform API, we don't have it implemented here but you can adapt the implementation we did for XCT.
3 participants
Description of Change
Implement the behavior for system navigation bar (android-specific).
Linked Issues
#103
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information