Skip to content

Windows Snackbar rewrite#1658

Merged
VladislavAntonyuk merged 8 commits intomainfrom
feature/snakbar-rewrite
Feb 19, 2024
Merged

Windows Snackbar rewrite#1658
VladislavAntonyuk merged 8 commits intomainfrom
feature/snakbar-rewrite

Conversation

@VladislavAntonyuk
Copy link
Copy Markdown
Contributor

@VladislavAntonyuk VladislavAntonyuk commented Jan 24, 2024

Replaces ToastNotification with AppNotificationManager. Fixes Snackbar and Toast execute new instance of the app

Description of Change

Linked Issues

PR Checklist

Additional information

Replaces ToastNotification with AppNotificationManager. Fixes Snackbar and Toast execute new instance of the app
@VladislavAntonyuk VladislavAntonyuk requested a review from a team January 24, 2024 20:18
@VladislavAntonyuk VladislavAntonyuk self-assigned this Jan 24, 2024
Comment thread samples/CommunityToolkit.Maui.Sample/Platforms/Windows/Package.appxmanifest Outdated
@VladislavAntonyuk VladislavAntonyuk added the needs discussion Discuss it on the next Monthly standup label Jan 30, 2024
@VladislavAntonyuk VladislavAntonyuk requested a review from a team February 2, 2024 10:14
Copy link
Copy Markdown
Member

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/CommunityToolkit.Maui/AppBuilderExtensions.shared.cs
Comment thread src/CommunityToolkit.Maui/AppBuilderExtensions.shared.cs
@pictos pictos added the pending documentation This feature requires documentation label Feb 15, 2024
@VladislavAntonyuk VladislavAntonyuk removed the needs discussion Discuss it on the next Monthly standup label Feb 19, 2024
@VladislavAntonyuk VladislavAntonyuk enabled auto-merge (squash) February 19, 2024 16:35
@VladislavAntonyuk VladislavAntonyuk merged commit 3cda1bd into main Feb 19, 2024
@VladislavAntonyuk VladislavAntonyuk deleted the feature/snakbar-rewrite branch February 19, 2024 16:35
@TheCodeTraveler TheCodeTraveler added breaking change This label is used for PRs that include a breaking change and removed pending documentation This feature requires documentation labels Mar 28, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking change This label is used for PRs that include a breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Application crashes under Windows when running in desktop mode [Bug] Snackbar opens a new app process on Windows

4 participants