Add popup size update on iOS#1653
Merged
TheCodeTraveler merged 7 commits intoCommunityToolkit:mainfrom Mar 25, 2024
Merged
Conversation
Contributor
Author
|
As an aside, I tried updating the View's Bounds within the method below, but it didn't work as intended. [src\CommunityToolkit.Maui.Core\Handlers\Popup\PopupHandler.macios.cs] [src\CommunityToolkit.Maui.Core\Views\Popup\PopupExtensions.macios.cs] The update within the ViewWillTransitionToSize method worked as intended. |
Contributor
Contributor
Author
|
@bijington , I left a comment that updating the View's Bounds works as intended with the ViewWillTransitionToSize method, not the MapSize, SetSize methods. |
|
Can we get this merged please? It's been 2 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where Gestures do not work on Popups when changing the Popup's Size property.
Description of Change
Bounds of a UIView placed in a Popup will not be updated after calling the SetView method.
[src\CommunityToolkit.Maui.Core\Views\Popup\MauiPopup.macios.cs]
Therefore, update the View's Bounds in the method below that is called when the View's size is updated.
[src\CommunityToolkit.Maui.Core\Views\Popup\MauiPopup.macios.cs]
This will update the View's Bounds and allow the Gesture to work even after the size update.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Below is the verification video.
I used the issue reproduction code for verification.
iPhone.15.iOS.17.0.2024-01-19.15-35-07.mp4
You can see that the Gesture is still working after updating the Popup's size.