Android File Saver - remove MemoryStream#1637
Merged
VladislavAntonyuk merged 3 commits intomainfrom Feb 1, 2024
Merged
Conversation
VladislavAntonyuk
force-pushed
the
bugfix/android-file-saver
branch
2 times, most recently
from
1a3894c to
55cbf84
Compare
VladislavAntonyuk
force-pushed
the
bugfix/android-file-saver
branch
from
55cbf84 to
e133a86
Compare
bijington
approved these changes
Jan 6, 2024
Contributor
bijington
left a comment
bijington
left a comment
There was a problem hiding this comment.
Looks good to me! Just a minor question that likely just helps me understand something better :)
pictos
approved these changes
Jan 6, 2024
Member
pictos
left a comment
pictos
left a comment
There was a problem hiding this comment.
LGTM!
Just double checking, did you try to save a large file?
Contributor
Author
|
it was verified with a 1 GB file on the emulator with 1 GB RAM. https://downloadtestfile.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information