Memory leak on TintedImageBehavior fix#1625
Merged
bijington merged 5 commits intoCommunityToolkit:mainfrom Feb 14, 2024
Marioo1357:IconTintBevavior-Fix
Merged
Memory leak on TintedImageBehavior fix#1625bijington merged 5 commits intoCommunityToolkit:mainfrom Marioo1357:IconTintBevavior-Fix
bijington merged 5 commits intoCommunityToolkit:mainfrom
Marioo1357:IconTintBevavior-Fix
Conversation
Every time when color was applied, the void was added to event handler. It causes that every next ImageSource change, invoked heavy color logic multiple times
Contributor
Author
|
@dotnet-policy-service agree |
VladislavAntonyuk
approved these changes
Dec 29, 2023
Contributor
VladislavAntonyuk
left a comment
VladislavAntonyuk
left a comment
There was a problem hiding this comment.
Thank you!
Just add some explanation: we subscribe to OnElementPropertyChanged only once - OnAttached - instead of each time the TintColor is changed
Contributor
Author
|
PR has:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We subscribe to OnElementPropertyChanged only once - OnAttached - instead of each time the TintColor is changed
Every time when color was applied, the void was added to event handler. It causes that every next ImageSource change, invoked heavy color logic multiple times
Description of Change
Move dispose and subscibe logic right place in ImageTintBehavior
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information