[housekeeping] Automated PR to fix formatting errors#1563
Merged
TheCodeTraveler merged 4 commits intomainfrom Feb 15, 2024
Merged
[housekeeping] Automated PR to fix formatting errors#1563TheCodeTraveler merged 4 commits intomainfrom
TheCodeTraveler merged 4 commits intomainfrom
Conversation
github-actions
Bot
added
the
approved
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
from
2fded80 to
8c9d966
Compare
TheCodeTraveler
removed
the
approved
github-actions
Bot
added
the
approved
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
from
8c9d966 to
9177ee6
Compare
Member
|
Aggressive bot being aggressive 😄 I guess we want to hold of merging because of those obsolete attributes? |
Collaborator
Agreed. It's because We won't be able to get rid of this noise until we upgrade MediaElement away from ExoPlayer, but we're blocked on that: #1511 |
Contributor
|
Would it be a bad thing to suppress those warnings just for that part of the namespace until we solve it? |
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
2 times, most recently
from
952ff73 to
a1dbd31
Compare
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
from
a1dbd31 to
bd3f453
Compare
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
from
bd3f453 to
0d3145b
Compare
TheCodeTraveler
removed
the
approved
github-actions
Bot
added
the
approved
TheCodeTraveler
added
blocked
and removed
approved
github-actions
Bot
added
the
approved
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
from
0d3145b to
14af845
Compare
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
2 times, most recently
from
3a41b60 to
1d63d57
Compare
github-actions
Bot
force-pushed
the
housekeeping/fix-codeformatting
branch
from
1d63d57 to
8eff768
Compare
This reverts commit 8eff768.
TheCodeTraveler
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to fix formatting errors