fix(table): restore expected behavior in table_matches#49
Merged
FjamZoo merged 1 commit intoCommunityOx:mainfrom Sep 10, 2025
Merged
fix(table): restore expected behavior in table_matches#49FjamZoo merged 1 commit intoCommunityOx:mainfrom
FjamZoo merged 1 commit intoCommunityOx:mainfrom
Conversation
rukshanchamindu
commented
Sep 9, 2025
rukshanchamindu
commented
- The refactor in Commit 4c460e0 introduced stricter type checks (using table.type and array length comparison), which caused empty tables and tables with nil values to be considered unequal.
- This commit removes the strict shape checks and restores the original deep equality semantics, ensuring {} == {x=nil}.
- The refactor in [Commit 4c460e0](CommunityOx@4c460e0) introduced stricter type checks (using table.type and array length comparison), which caused empty tables and tables with nil values to be considered unequal. - This commit removes the strict shape checks and restores the original deep equality semantics, ensuring {} == {x=nil}. Signed-off-by: RuksH4n <[email protected]>
FjamZoo
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.