Feature: Added definable dataset for fivemanage logging#45
Merged
antond15 merged 2 commits intoCommunityOx:mainfrom Sep 4, 2025
Merged
Feature: Added definable dataset for fivemanage logging#45antond15 merged 2 commits intoCommunityOx:mainfrom
antond15 merged 2 commits intoCommunityOx:mainfrom
Conversation
Member
Author
|
Still need to test it on a server, will do when able. I'm also tempted to alter the behaviour to have the header value added dynamically. local dataset = GetConvar('fivemanage:dataset', '')
if key ~= '' then
local endpoint = 'https://api.fivemanage.com/api/logs/batch'
local headers = {
['Content-Type'] = 'application/json',
['Authorization'] = key,
['User-Agent'] = 'ox_lib
}
if dataset then
headers['X-Fivemanage-Dataset'] = dataset
endEDIT: I went with this approach, seemed more "user friendly" as it's possible they might have renamed or deleted the dataset. Should avoid any complaints coming through of it not logging. |
…r for it isn't set -> will let fivemanage determine the "default" dataset to use
|
Tested on my server, Working great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple convar that server owners can set to define the dataset they want to use when using ox_lib logger alongside fivemanage.
Details:
fivemanage:dataset"default"According to the outcome of this PR, another will be made for updating the documentation relating to this change.