Add support for a NamespacedKey variant for the PotionEffectArgument#541
Merged
DerEchtePilz merged 4 commits intodev/devfrom Apr 25, 2024
Merged
Conversation
DerEchtePilz
force-pushed
the
dev/namespaced-key-potion-effect-argument
branch
2 times, most recently
from
79ca29d to
09e11d9
Compare
DerEchtePilz
force-pushed
the
dev/namespaced-key-potion-effect-argument
branch
from
eef2246 to
c9ffb55
Compare
JorelAli
reviewed
Apr 23, 2024
Member
JorelAli
left a comment
JorelAli
left a comment
There was a problem hiding this comment.
No tests?
We have tests for other NamespacedKey arguments, such as SoundArgument.NamespacedKey and BiomeArgument.NamespacedKey
DerEchtePilz
force-pushed
the
dev/namespaced-key-potion-effect-argument
branch
4 times, most recently
from
fff2cf0 to
d80dab0
Compare
DerEchtePilz
force-pushed
the
dev/namespaced-key-potion-effect-argument
branch
from
d80dab0 to
82bcce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.