Merged
Conversation
2 tasks
46558a5 to
9babcd2
Compare
9babcd2 to
330f113
Compare
Merged
9102ea7 to
bfbe182
Compare
bfbe182 to
c5d49e1
Compare
Closed
4dba32a to
9f28b25
Compare
b088d05 to
a93af70
Compare
18e8c28 to
f80d789
Compare
36ca865 to
acda2d1
Compare
DerEchtePilz
added a commit
that referenced
this pull request
May 12, 2024
+ fixed exception appearing in server log, this isn't done with VarHandles but I think because this is a hotfix, it is fine for now. I will handle all this properly on dev/commandapi-paper and #517
f9a99ef to
c357912
Compare
a81dd6b to
66db468
Compare
6b8070a to
904dc4b
Compare
willkroboth
reviewed
Aug 24, 2024
willkroboth
requested changes
Aug 24, 2024
7d2a622 to
3e6e617
Compare
9fc3dc2 to
f4a9ec9
Compare
DerEchtePilz
added a commit
to CommandAPI/docs
that referenced
this pull request
Feb 17, 2025
f4a9ec9 to
647bcab
Compare
willkroboth
reviewed
Jun 19, 2025
Collaborator
willkroboth
left a comment
There was a problem hiding this comment.
Just some thoughts. It looks like the docs PR has some catching up to do.
…gument to be more inline with Paper
Needs more testing.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors parts of the CommandAPI so the Adventure library and Bungee library aren't used in the same .jar's anymore and Paper API and Spigot API also aren't used together anymore.
In order to do that,
commandapi-bukkit-coreonly serves as a tool to access NMS so it can be shared and doesn't have to be implemented again for Paper and Spigot.The new usable platforms are
commandapi-paper-(core/shade/plugin)andcommandapi-spigot-(core/shade/plugin).This still requires a lot of work. I am fairly confident that these changes should already make a fairly functional CommandAPI for Paper and Spigot, however, there still is a lot of work left.
This should also invalidate #474 as this refactor puts them into different modules
TODO's:
PaperImplementations.javaCommandAPIBukkitand implement inCommandAPIPaperandCommandAPISpigotrespectively.commandapi-annotationsplatform specific (Component related arguments)Update tests to useNope, cancelling those. The original tests are still present but they won't work. After trying to port tests two times I do not really know what to do so if someone else at some point, possibly after this is merged, has an idea this could and should be implemented.CommandAPIPaperorCommandAPISpigot. Maybe even both, share tests and implement component related arguments for both platformsminecraftnamespace exists for commands on Papercommandapi-paper-shade-mojang-mapped)commandapi-paper-shade-mojang-mapped)