Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java.lang.NoSuchFieldError: Class net.minecraft.server.MinecraftServer does not have member field 'net.minecraft.commands.Commands vanillaCommandDispatcher' after upgrading to Paper-1.20.6-b68 #554

Closed
globau opened this issue May 12, 2024 · 8 comments · May be fixed by #517
Closed

java.lang.NoSuchFieldError: Class net.minecraft.server.MinecraftServer does not have member field 'net.minecraft.commands.Commands vanillaCommandDispatcher' after upgrading to Paper-1.20.6-b68 #554

globau opened this issue May 12, 2024 · 8 comments · May be fixed by #517
Labels
bug Something isn't working currently hotfixed Something that's fixed/implemented but not fixed properly

Comments

@globau
Copy link

globau commented May 12, 2024 •
edited
Loading

CommandAPI version

9.4.0

Minecraft version

1.20.6

Are you shading the CommandAPI?

Yes

What I did

What actually happened

All plugins using CommaAPI fail to load

What should have happened

Business as usual

Server logs and CommandAPI config

java.lang.NoSuchFieldError: Class net.minecraft.server.MinecraftServer does not have member field 'net.minecraft.commands.Commands vanillaCommandDispatcher'
        at ClodMC.jar/shadow.dev.jorel.commandapi.nms.NMS_Common.getBrigadierDispatcher(NMS_Common.java:353) ~[ClodMC.jar:?]
        at ClodMC.jar/shadow.dev.jorel.commandapi.CommandAPIBukkit.registerCommandNode(CommandAPIBukkit.java:641) ~[ClodMC.jar:?]
        at ClodMC.jar/shadow.dev.jorel.commandapi.CommandAPIHandler.register(CommandAPIHandler.java:647) ~[ClodMC.jar:?]
        at ClodMC.jar/shadow.dev.jorel.commandapi.AbstractCommandAPICommand.register(AbstractCommandAPICommand.java:307) ~[ClodMC.jar:?]
        at ClodMC.jar/shadow.dev.jorel.commandapi.CommandAPICommand.register(CommandAPICommand.java:60) ~[ClodMC.jar:?]
        at ClodMC.jar/shadow.dev.jorel.commandapi.ExecutableCommand.register(ExecutableCommand.java:236) ~[ClodMC.jar:?]
        …

Other

Downgrading to Paper-1.20.6-b62 fixed the issue.

Probably caused by PaperMC/Paper#8235

ps. your issue template doesn't have mc v1.20.6.
@globau globau added the bug Something isn't working label May 12, 2024
@DerEchtePilz
Copy link
Member

Yeah, definitely caused by Paper‘s Brigadier PR; until we have a (hot)fix it might be best to stay on build 64

@DerEchtePilz
Copy link
Member

@globau
Just to clarify, when you load a plugin using the CommandAPI on a Paper server with the Paper Brigadier command API, does the plugin actually get disabled?

@willkroboth willkroboth mentioned this issue May 12, 2024
Closed
@Sytm
Copy link
Contributor

Sytm commented May 12, 2024

One of my users also ran into this problem. This is the full exception: https://pastes.dev/JDnzZIMiXs
As you can see my plugin is also disabled because of this (if this is what you meant)

@DerEchtePilz
Copy link
Member

One of my users also ran into this problem. This is the full exception: https://pastes.dev/JDnzZIMiXs As you can see my plugin is also disabled because of this (if this is what you meant)

Thanks! I currently have a hotfix on dev/paper-hotfix (PR #555) if you want to check it out.
Just waiting on approval and/or feedback but it should work.

@DerEchtePilz DerEchtePilz added the currently hotfixed Something that's fixed/implemented but not fixed properly label May 12, 2024
@DerEchtePilz
Copy link
Member

This is now hotfixed in snapshot version 9.5.0-SNAPSHOT
It will take a while for it to deploy but once it is deployed, this issue is hotfixed.

@DerEchtePilz DerEchtePilz linked a pull request May 13, 2024 that will close this issue
Paper CommandAPI #517
Open
27 tasks
@frengor
Copy link

frengor commented May 14, 2024

Any plans on when 9.5.0 will be released? We're currently waiting for this to be fixed before releasing the new version of UltimateAdvancementAPI.

(no need to hurry, just to know, hope it isn't a month 💀)

@DerEchtePilz
Copy link
Member

@frengor
Yeah, if released it probably will rather be 9.4.2 but @JorelAli is currently on a break so it might take until the end of the month.

frengor added a commit to frengor/UltimateAdvancementAPI that referenced this issue May 14, 2024
@frengor
Update CommandAPI to 9.5.0-SNAPSHOT
4182ad4 
CommandAPI 9.5.0-SNAPSHOT is shaded as a workaround for CommandAPI/CommandAPI#554 (comment)
@Zoriot Zoriot mentioned this issue May 18, 2024
Merged
@Sytm Sytm mentioned this issue May 24, 2024
Closed
@JorelAli
Copy link
Member

Hotfix has been published to CommandAPI 9.4.2. For all intents and purposes, this should now be fixed for paper builds 64+

willkroboth added a commit that referenced this issue May 30, 2024
@willkroboth
Delegate Bukkit command registering logic to `CommandRegistrationStra…
66849a6 
…tegy`

Just a rough example implementation

`NMS#getResourceDispatcher` replaced by `NMS#createCommandRegistrationStrategy`, which creates a `SpigotCommandRegistration` implementation using the resources dispatcher

Alternate fix for #554. If we're on Paper-1.20.6-65, a `PaperCommandRegistration` implementation is used instead. This can be used to properly handle the internal changes made by PaperMC/Paper#8235.
willkroboth added a commit that referenced this issue Jun 3, 2024
@willkroboth
Delegate Bukkit command registering logic to `CommandRegistrationStra…
a0b1046 
…tegy`

Just a rough example implementation

`NMS#getResourceDispatcher` replaced by `NMS#createCommandRegistrationStrategy`, which creates a `SpigotCommandRegistration` implementation using the resources dispatcher

Alternate fix for #554. If we're on Paper-1.20.6-65, a `PaperCommandRegistration` implementation is used instead. This can be used to properly handle the internal changes made by PaperMC/Paper#8235.
DerEchtePilz pushed a commit that referenced this issue Jun 6, 2024
@willkroboth @DerEchtePilz
Delegate Bukkit command registering logic to `CommandRegistrationStra…
0355efa 
…tegy`

Just a rough example implementation

`NMS#getResourceDispatcher` replaced by `NMS#createCommandRegistrationStrategy`, which creates a `SpigotCommandRegistration` implementation using the resources dispatcher

Alternate fix for #554. If we're on Paper-1.20.6-65, a `PaperCommandRegistration` implementation is used instead. This can be used to properly handle the internal changes made by PaperMC/Paper#8235.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working currently hotfixed Something that's fixed/implemented but not fixed properly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Paper CommandAPI CommandAPI/CommandAPI
5 participants
@globau @JorelAli @Sytm @frengor @DerEchtePilz