This repository was archived by the owner on May 3, 2019. It is now read-only.
Fix Spotify integration script#258
Merged
ColinDuquesnoy merged 2 commits intoColinDuquesnoy:developfrom Jul 6, 2018
Merged
Conversation
The Spotify integration script had several errors preventing successful extraction of metadata: - getArtist() and getSongTitle() were attempting to use the non-existent .text DOM Node property. Fixed to use .innerText - getArtUrl() was using an outdated css selector to access the album art div - isFavorite() was failing with an error if getButtons().addRemoveToMusic was null, which can be the case shortly after page load. Added a check for this.
Owner
|
That looks good 👍 Thank you very much! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spotify integration script had several errors preventing successful
extraction of metadata:
getArtist()andgetSongTitle()were attempting to use the non-existent.textDOM Node property. Fixed to use.innerTextgetArtUrl()was using an outdated css selector to access the album art divisFavorite()was using a regex to check the heart icon element for an*added*class to determine if the song is a favorite, but Spotify has since changed their class names to*active*for favorited songs.isFavorite()was failing with an error ifgetButtons().addRemoveToMusicwasnull, which can be the case shortly after page load. Added a check for this.