Skip to content
This repository was archived by the owner on May 3, 2019. It is now read-only.

Youtube plugin improvements#229

Merged
ColinDuquesnoy merged 2 commits intoColinDuquesnoy:developfrom
NicolasGuilloux:develop
May 8, 2018
Merged

Youtube plugin improvements#229
ColinDuquesnoy merged 2 commits intoColinDuquesnoy:developfrom
NicolasGuilloux:develop

Conversation

@NicolasGuilloux
Copy link
Contributor

@NicolasGuilloux NicolasGuilloux commented May 7, 2018 •
edited
Loading

Fixes

Fix the youtube persistent information. Disable the preview button when the player is outside a playlist.
Fix #218 Add the ads control. It will mute during the ad and skip it automatically.

@NicolasGuilloux
Fix of persistent information
a820781 
Fix the persistent information by checking if the page really contains one player.
Also disable the previous button if there is no playlist. The next button remains available as it allows the user to select the next video.
@NicolasGuilloux
Copy link
Contributor Author

NicolasGuilloux commented May 7, 2018

I don't understand why the check failed. It works on my computer very well :(

@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented May 8, 2018

Thank you for your contribution!

I don't understand why the check failed. It works on my computer very well :(

Don't worry about it, this was just an intermittent infrastructure issue (chocolatey failed to download qbs). I've rebuild your PR and the check now passes on AppVeyor...

About the PR, may I ask you to split the PR in two and close this one? (one for the youtube plugin fix and another for kodi)
It seems like the PR fixes #218, so, please add a comment with "fix #218" in the new youtube PR so that the corresponding issue will get closed automatically when I'll merge the PR (see Closing Issues via Pull Requests )

About the kodi plugin, I have a few minor nitpicks:

  1. use lowercase for the plugin directory
  2. Use white instead of blue in the kodi logo (so that the logo looks consistent with other logos)

@NicolasGuilloux NicolasGuilloux changed the title Youtube plugin Fix. New Kodi plugin. Youtube plugin Fix. May 8, 2018
@NicolasGuilloux
Copy link
Contributor Author

NicolasGuilloux commented May 8, 2018

Okay I really struggle to use Git. I mean, I learned barely how to use it but it is the first time I use advanced features, so sorry for the many mistakes. I try to figure this out without messing up everything ;)

@NicolasGuilloux
Copy link
Contributor Author

NicolasGuilloux commented May 8, 2018 •
edited
Loading

Okay I made things clear, wonderful! I definitely need to practice ;) This pull request looks ready to go!

For the Kodi stuff, as I found a bug, I will first solve it and then create a new pull request to avoid spamming your git.

@ColinDuquesnoy ColinDuquesnoy merged commit f893239 into ColinDuquesnoy:develop May 8, 2018
@ColinDuquesnoy
Copy link
Owner

ColinDuquesnoy commented May 8, 2018

Okay I made things clear, wonderful! I definitely need to practice ;) This pull request looks ready to go!

Thank you! 👏

For the Kodi stuff, as I found a bug, I will first solve it and then create a new pull request to avoid spamming your git.

Fine 👍

@ColinDuquesnoy ColinDuquesnoy changed the title Youtube plugin Fix. Youtube plugin improvements May 8, 2018
@ColinDuquesnoy ColinDuquesnoy added this to the 3.4.0 milestone May 8, 2018
@cpjeanpaul cpjeanpaul mentioned this pull request Jul 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug feature

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@NicolasGuilloux @ColinDuquesnoy