You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 3, 2019. It is now read-only.
GPM Plugin - properly handle cases when we can't go to next/previous.
Example: when repeat is disabled and the last track in the queue finishes playing GPM disables next and previous buttons and clicking on them does nothing (play button still works).
MellowPlayer should handle such cases correctly so that it does not display active next and previous buttons in it's toolbar/MPRIS applet when it can't actually skip to next/previous song
MellowPlayer should handle such cases correctly so that it does not display active next and previous buttons in it's toolbar/MPRIS applet when it can't actually skip to next/previous song
I've tested with deezer, MellowPlayer disable the next/previous buttons correctly in the toolbar (the button is semi transparent to indicate it cannot be used). Are you saying this does not work for you or do you mean they should be hidden instead of being disabled?
Are you saying this does not work for you or do you mean they should be hidden instead of being disabled?
My comment is only relevant for that particular case in Google Play Music
when repeat is disabled and the last track in the queue finishes playing GPM disables next and previous buttons and clicking on them does nothing (play button still works).
In this scenario next and previous buttons were not semi transparent without this commit. In other services (e.g. Youtube) it works as expected.
Ok, I misunderstood your last sentence. Thank you for your contribution!
ColinDuquesnoy
changed the title
GPM - handle cases when we can't go to next/previous
GPM: handle cases when we can't go to next/previous
May 8, 2018
ColinDuquesnoy
changed the title
GPM: handle cases when we can't go to next/previous
Google Play Music: handle cases when we can't go to next/previous
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GPM Plugin - properly handle cases when we can't go to next/previous.
Example: when repeat is disabled and the last track in the queue finishes playing GPM disables next and previous buttons and clicking on them does nothing (play button still works).
MellowPlayer should handle such cases correctly so that it does not display active next and previous buttons in it's toolbar/MPRIS applet when it can't actually skip to next/previous song